Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure $new_comments in Comment\QueryIntegration::maybe_filter_query() is an array #3127

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #3123

Changelog Entry

Fixed - PHP Warning when a post has no comments

Credits

Props @felipeelia and @JiveDig

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.4.0 milestone Nov 9, 2022
@felipeelia felipeelia self-assigned this Nov 9, 2022
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit cd9ae7a into develop Nov 9, 2022
@felipeelia felipeelia deleted the fix/issue-3123 branch November 9, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants