Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notice for Instant Results in network mode. #3149

Merged
merged 5 commits into from
Nov 23, 2022

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Nov 23, 2022

Description of the Change

Adds a notice to the Instant Results feature when ElasticPress is network activated. The notice links to an article which will explain how to save the search template using WP CLI so that Instant Results works for all sites on the network.

Screenshot 2022-11-23 at 11 01 46 pm

Closes #3138

How to test the Change

  1. Network Activate WooCommerce.
  2. In ElasticPress > Features there should be a warning message in the Instant Results box.

Changelog Entry

Added - A notice to the Instant Results feature settings when ElasticPress is network activated that warns that Instant Results will not work on all sites without additional steps, with a link to an article that describes the required steps.

Credits

Props @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT JakePT added this to the 4.4.0 milestone Nov 23, 2022
@JakePT JakePT self-assigned this Nov 23, 2022
@felipeelia felipeelia merged commit d46c7d5 into develop Nov 23, 2022
@felipeelia felipeelia deleted the feature/instant-results-network-notice branch November 23, 2022 16:46
felipeelia added a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Instant Results search template is only saved for the main site of a multisite network
2 participants