-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop the Sync process if mapping failed #3206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burhandodhy
force-pushed
the
fix/3204
branch
from
December 15, 2022 07:16
d33508e
to
859c1d9
Compare
burhandodhy
changed the title
[WIP] Stop the Sync process if mapping failed
Stop the Sync process if mapping failed
Dec 15, 2022
felipeelia
requested changes
Dec 16, 2022
felipeelia
requested changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR updates the
put_mapping
method to return theWP_ERROR
object in case there is issue while doing the mapping. The main reason to doing this is so we can stop the sync if there is an error and also shows the error message in dashboard and WP CLI commandCloses #3204
How to test the Change
put-mapping
command and it should display the error messageChangelog Entry
Credits
Props @burhandodhy @felipeelia
Checklist: