Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy filter from WooCommerce Feature class #3230

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR removes the filters code that doesn't exist anymore in WooCommerce and EP. woocommerce_layered_nav_query_post_ids and woocommerce_unfiltered_product_ids was remove in WooCommerce 2.6.

Closes #

How to test the Change

Changelog Entry

Removed - Remove legacy filters woocommerce_layered_nav_query_post_ids, woocommerce_unfiltered_product_ids and ep_wp_query_search_cached_posts code

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.4.1 milestone Dec 22, 2022
@felipeelia felipeelia modified the milestones: 4.4.1, 4.5.0 Jan 4, 2023
@felipeelia felipeelia assigned burhandodhy and unassigned felipeelia Jan 4, 2023
@felipeelia
Copy link
Member

@burhandodhy I'm postponing this to be released in 4.5.0. For that to happen, we will also need to break this into two phases:

  1. For 4.5.0 we remove the method's body and replace it with a _doing_it_wrong() or similar
  2. For 5.0.0 we really remove them

Both methods have been around for too long now and simply removing them could break someone else's code.

@felipeelia felipeelia merged commit db11e9a into develop Jan 20, 2023
@felipeelia felipeelia deleted the chore/remove-legacy-code branch January 20, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants