Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent doubled requests #3265

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Prevent doubled requests #3265

merged 3 commits into from
Jan 19, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

Visiting the Status Report page will make all the ES requests twice. This PR addresses this problem, using the same instance of the StatusReport page and storing the processed/formatted reports in an attribute.

How to test the Change

  1. Install Query Monitor
  2. Visit the Status Report page and look at the HTTP API Calls
  3. Checkout this PR
  4. See the numbers cut in half

Changelog Entry

Fixed - Status Report page firing requests to ES twice.

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.5.0 milestone Jan 19, 2023
@felipeelia felipeelia self-assigned this Jan 19, 2023
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit c52500b into develop Jan 19, 2023
@felipeelia felipeelia deleted the fix/status-report-proc-twice branch January 19, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants