Prevent using the EP if query has unsuported orderby #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Jan 31, 2023
There was a problem hiding this comment.
@burhandodhy WP_Query's orderby also accepts an array and we need to account for that as well. Instead of checking
if ( in_array( $query->get( 'orderby' ), $unsupported_orderby, true ) ) {we could do something like
if ( array_intersect( (array) $query->get( 'orderby' ), $unsupported_orderby ) ) {
felipeelia
requested changes
Feb 2, 2023
Comment on lines
791
to
797
| /** | ||
| * If WP_Query has unsupported orderby, skip ES query integration and use the WP query instead. | ||
| * | ||
| * @param bool $skip Whether to skip ES query integration | ||
| * @param \WP_Query $query WP_Query object | ||
| * @since 4.5 | ||
| */ |
There was a problem hiding this comment.
@burhandodhy can we please document the function return as well?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR prevents WordPress to use Elasticsearch if the Query does have unsupported orderby value
Closes #3272
How to test the Change
Changelog Entry
Credits
Props @burhandodhy
Checklist: