Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing currency for price range facet. #3293

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Fix missing currency for price range facet. #3293

merged 4 commits into from
Feb 2, 2023

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Feb 2, 2023

Description of the Change

Fixes an issue in Instant Results where a currency was not used when formatting prices, which would cause Instant Results to crash when the price range facet was used. Also includes tests for the price range facet.

Closes #3279

How to test the Change

  1. Activate WooCommerce.
  2. Activate Instant Results.
  3. Add Price range to the Instant Results facets.
  4. Sync.
  5. Perform a search for products.
  6. Instant Results should function as expected, and the price range facet should work as expected.

Changelog Entry

N/A, fixes an issue that does not exist in a release version.

Credits

Props @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.5.0 milestone Feb 2, 2023
@felipeelia felipeelia merged commit 3bbabd3 into develop Feb 2, 2023
@felipeelia felipeelia deleted the fix/3279 branch February 2, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Instant Results Price facet not working in develop
2 participants