Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New X-ElasticPress-Request-ID header #3307

Merged
merged 4 commits into from
Feb 13, 2023
Merged

New X-ElasticPress-Request-ID header #3307

merged 4 commits into from
Feb 13, 2023

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Feb 8, 2023

Description of the Change

Closes #3305

How to test the Change

Changelog Entry

Added - Requests now have a new header called X-ElasticPress-Request-ID to help with debugging.

Credits

Props @felipeelia, @dustinrue

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.5.0 milestone Feb 8, 2023
@JakePT JakePT self-requested a review February 10, 2023 03:40
assets/js/api-search/src/hooks.js Show resolved Hide resolved
@felipeelia
Copy link
Member Author

I am merging this as is, after a conversation with Jacob via slack. The main reason why the generateRequestId isn't in the API is that it is also used by autosuggest, which does not use an API-driven approach yet. When it comes, we can bring that function in, and fix the API encapsulation again.

@felipeelia felipeelia merged commit de9f6c0 into develop Feb 13, 2023
@felipeelia felipeelia deleted the feature/issue-3305 branch February 13, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New HTTP Header in all Requests
2 participants