Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facets - Display term count #3309

Merged
merged 6 commits into from
Feb 15, 2023
Merged

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Feb 9, 2023

Description of the Change

This PR adds a new toggle to both Facets blocks, so the user can display or not the term count in each facet. This PR also makes some small changes in the way one can get settings values from a feature:

  • get_settings() now return default values as well
  • A new get_setting() method was introduced

Closes #3286

How to test the Change

  1. Create some facet blocks (taxonomy and meta)
  2. Change the Display Term Count toggle to see it displaying or hiding the term count

Changelog Entry

Added - Option to display term counts in Facets blocks

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.5.0 milestone Feb 9, 2023
@felipeelia felipeelia changed the title [WIP] Facets - Display term count Facets - Display term count Feb 14, 2023
@felipeelia felipeelia merged commit e1f8982 into develop Feb 15, 2023
@felipeelia felipeelia deleted the feature/facets-display-count branch February 15, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Term counts not showing in facet widget
2 participants