Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom capability for managing ElasticPress #3313

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

tlovett1
Copy link
Member

This adds a new capability for managing ElasticPress and adds it to the admin role.

The point of this change is it allows people to add the capability to non-admins. Right now, that's not possible since everything goes off of manage_options.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@tlovett1 tlovett1 added the new feature Label for new, potentially bigger features label Feb 12, 2023
@felipeelia felipeelia added this to the 4.5.0 milestone Feb 12, 2023
@felipeelia felipeelia self-assigned this Feb 12, 2023
@tott
Copy link
Contributor

tott commented Feb 14, 2023

@tlovett1 this is a great suggestion and we will make sure this gets rolled into the 4.5 release currently scheduled for march. We will want to do some changes to the suggested code to ensure backward compatibility and performance integrity.

@tlovett1
Copy link
Member Author

Thanks @tott

@felipeelia felipeelia merged commit 452294e into develop Feb 20, 2023
@felipeelia felipeelia deleted the feature/permissions branch February 20, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Label for new, potentially bigger features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants