Fix #3325 Set the current post when indexing posts #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When indexing a post, the content gets rendered, and shortcodes/blocks/etc may rely on the global `$post` variable to provide context that will be missing when performing an ES index. In my case it was a block which did not handle the value being missing, but context dependent content would generate PHP warnings/errors or incorrect data
|
Making this PR via the web interface, I don't have a lot of bandwidth right now to dig into things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
When indexing a post, the content gets rendered, and shortcodes/blocks/etc may rely on the global
$postvariable to provide context that will be missing when performing an ES index.In my case it was a block which did not handle the value being missing, but context dependent content would generate PHP warnings/errors or incorrect data
By setting the global
$postand the current postdata, we can avoid some of these situations. This enabled indexing to continue locally where it would fail previously.Closes #3325
How to test the Change
In my case, I did not check the
postIdin the block context for presence and used it without verification. This lead to a fatal error which is avoided when using this PRChangelog Entry
Credits
Props @tomjn
Checklist: