Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally load the Users feature #3334

Merged
merged 6 commits into from
Feb 27, 2023
Merged

Conditionally load the Users feature #3334

merged 6 commits into from
Feb 27, 2023

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Feb 21, 2023

Description of the Change

This PR introduces a few things:

  • Notices warning about the Users feature migration to EP Labs
  • A new ep_user_register_feature filter that determines whether the Users feature should be loaded or not. It is true by default but will be false for users of a newer version of EP Labs
  • A new ep_feature_is_visible filter to determine if a feature should or should not be visible in the dashboard. All features are still visible by default but that will change in EP 5.0.0. Active features are always visible.

Closes #3180

How to test the Change

Changelog Entry

Added - New ep_user_register_feature and ep_feature_is_visible filters.

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.5.0 milestone Feb 21, 2023
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@felipeelia felipeelia merged commit 6e68bc9 into develop Feb 27, 2023
@felipeelia felipeelia deleted the chore/issue-3180 branch February 27, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the Users Indexable to ElasticPress Labs
2 participants