Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet by Meta Range block UI. #3337

Merged
merged 12 commits into from
Mar 1, 2023
Merged

Facet by Meta Range block UI. #3337

merged 12 commits into from
Mar 1, 2023

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Feb 23, 2023

Description of the Change

Adds a range slider UI for the Facet by Meta Range block.

Screenshot 2023-02-23 at 5 57 40 pm

Also updates the block preview with a preview of the slider, a message when a preview is unavailable, and a wizard for selecting a field when adding the block for the first time. The wizard is required to avoid a preview unavailable message being the first thing the user sees, and allows that message to include the field name since the wizard can be used when no field is selected.

Facet.by.meta.range.mp4

Closes #3291

E2E tests to come.

How to test the Change

  • Add the Facet by Range meta block.
    • When adding the block you should be prompted to choose a field.
    • After choosing a field you should see either:
      • A preview of the range slider. It should not be interactive.
      • A warning that the selected field is not numeric and cannot be used for the range slider.
    • On the front end the range slider should be interactive, and when the Filter button is pressed it should filter results by the selected range.
    • It should be possible to undo the range filter by reselecting the widest range of values.

Changelog Entry

See #3289

Credits

@JakePT @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT
Copy link
Contributor Author

JakePT commented Feb 23, 2023

Add prefix/suffix for meta values.

@JakePT JakePT changed the title WIP: Facet by Meta Range block UI. Facet by Meta Range block UI. Mar 1, 2023
@JakePT JakePT requested a review from felipeelia March 1, 2023 13:57
@JakePT JakePT marked this pull request as ready for review March 1, 2023 13:57
@JakePT JakePT added this to the 4.5.0 milestone Mar 1, 2023
@felipeelia felipeelia merged commit a057e6f into develop Mar 1, 2023
@felipeelia felipeelia deleted the feature/3291 branch March 1, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facet by Meta Block
2 participants