Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for status report #3395

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Add tests for status report #3395

merged 4 commits into from
Mar 31, 2023

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Mar 20, 2023

Description of the Change

This PR adds the unit tests for the Status Report feature.

Closes #3218

How to test the Change

Changelog Entry

Added - Unit tests for the Status Reports feature.

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy marked this pull request as ready for review March 20, 2023 06:35
@burhandodhy burhandodhy added this to the 5.0.0 milestone Mar 21, 2023
@burhandodhy burhandodhy assigned felipeelia and unassigned felipeelia Mar 21, 2023
@felipeelia felipeelia modified the milestones: 5.0.0, 4.5.1 Mar 29, 2023
@felipeelia felipeelia self-requested a review March 29, 2023 19:22
Copy link
Member

@felipeelia felipeelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code overall looks good @burhandodhy, thanks! Do you mind changing the @since tag to 4.5.1 and also double check if we didn't introduce anything recently that would be easy enough to update here?

@felipeelia felipeelia merged commit e2b5eb6 into develop Mar 31, 2023
@felipeelia felipeelia deleted the fix/3218 branch March 31, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Unit Tests coverage for Status Report
2 participants