Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React errors in WordPress 6.2 #3417

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fix React errors in WordPress 6.2 #3417

merged 2 commits into from
Apr 3, 2023

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Apr 1, 2023

Description of the Change

Fixes two React errors, including one which causes a crash in React 18/WordPress 6.2.

WordPress 6.2 will still display this console notice:

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

But Instant Results will continue to work.

Closes #3416

How to test the Change

Instant Results should not crash instantly when used in WordPress 6.2.

Changelog Entry

Fixed - A compatibility issue which prevented Instant Results from working in WordPress 6.2.

Credits

Props @JakePT

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@JakePT JakePT added this to the 4.5.1 milestone Apr 1, 2023
@JakePT JakePT self-assigned this Apr 1, 2023
@JakePT JakePT requested a review from felipeelia April 1, 2023 04:07
@felipeelia felipeelia merged commit 24fb01b into develop Apr 3, 2023
@felipeelia felipeelia deleted the fix/3416 branch April 3, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Instant Results and WordPress 6.2
2 participants