Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep taxonomy query parameters in Facets URLs #3422

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

felipeelia
Copy link
Member

Description of the Change

This is #3397 with tests and additional comments

Closes #3360

How to test the Change

Changelog Entry

Fixed - Facets removing taxonomy parameters in the URL when not using pretty permalinks.

Credits

Props @MARQAS @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Co-authored-by: Mohammed Razzaq <MARQAS@users.noreply.github.com>
@felipeelia felipeelia added this to the 4.5.1 milestone Apr 3, 2023
@felipeelia felipeelia mentioned this pull request Apr 3, 2023
4 tasks
@felipeelia felipeelia merged commit 7f68818 into develop Apr 3, 2023
@felipeelia felipeelia deleted the fix/issue-3360 branch April 3, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facet not working on category page.
2 participants