Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Facet Meta] Compatibility with block themes #3498

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Jun 16, 2023

Description of the Change

This PR adds compatibility with block themes for the two Facet meta blocks. It gets all blocks across all block templates and template parts and fields selected in all elasticpress/facet-meta* blocks instantiated.

To-Dos:

  • Cache layer
  • Tests

Closes #3378

How to test the Change

Use a FSE-compatible theme like Twenty Twenty Three, instantiate a Facet Meta block and see it working.

Changelog Entry

Added - Compatibility with block themes for the two Facet meta blocks.

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia changed the title WIP: [Facet Meta] Compatibility with block themes [Facet Meta] Compatibility with block themes Jul 28, 2023
@felipeelia felipeelia merged commit 91230c3 into develop Jul 28, 2023
9 checks passed
@felipeelia felipeelia deleted the fix/issue-3378 branch July 28, 2023 18:25
@felipeelia felipeelia added this to the 4.7.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Facet by Meta Range is not working with Block based themes
1 participant