Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and expand the orderby clause with meta fields #3512

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fix and expand the orderby clause with meta fields #3512

merged 1 commit into from
Jul 4, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

This PR fixes (and expands) the way ElasticPress handles orderby clauses with meta fields

Closes #3509

Changelog Entry

Fixed - Order by clauses with Elasticsearch field formats are not changed anymore

Credits

Props @felipeelia @tlovett1

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.7.0 milestone Jun 23, 2023
@felipeelia felipeelia mentioned this pull request Jun 23, 2023
Closed
@felipeelia felipeelia modified the milestones: 4.7.0, 4.6.1 Jun 26, 2023
@felipeelia felipeelia merged commit 65c8878 into develop Jul 4, 2023
8 checks passed
@felipeelia felipeelia deleted the fix/issue-3509 branch July 4, 2023 13:10
@felipeelia felipeelia mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burhandodhy burhandodhy burhandodhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

[Major Bug] PR 3469 breaks sorting in many cases
2 participants
@felipeelia @burhandodhy