Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on the health page #3530

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Jul 5, 2023

Description of the Change

This PR fixes the issue where the EP throws a warning Trying to access array offset on value of type bool on the Health page when there is no last sync information available.

Closes #

How to test the Change

  1. Run wp elasticpress settings-reset command.
  2. Go to health page wp-admin/site-health.php?tab=debug and make sure there is no waning

Changelog Entry

Fixed - Warning message on Health page when Last Sync information is not available.

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.6.1 milestone Jul 5, 2023
@felipeelia felipeelia merged commit 1d931e9 into develop Jul 5, 2023
8 checks passed
@felipeelia felipeelia deleted the fix/warning-on-health-page branch July 5, 2023 11:24
felipeelia added a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants