Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Did you Mean in Instant Results #3564

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Add Did you Mean in Instant Results #3564

merged 9 commits into from
Aug 8, 2023

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Jul 28, 2023

Description of the Change

This PR adds the suggestion from the Did You Mean feature in the Instant Results

Closes #3409

How to test the Change

  1. Enable Did You Mean and Instant Results
  2. Create a post with the same content and title, "10 Up Loves WordPress."
  3. Go to the frontend and search for" wordpre."
  4. The Instant Results modal should show the suggestion "WordPress"

Changelog Entry

Added - Integrate Did You Mean feature in the Instant Results

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy changed the title [WIP] Add Did you Mean in Instant Result Add Did you Mean in Instant Results Jul 28, 2023
@burhandodhy burhandodhy added this to the 4.7.0 milestone Jul 28, 2023
assets/js/instant-results/components/layout/results.js Outdated Show resolved Hide resolved
includes/classes/Feature/InstantResults/InstantResults.php Outdated Show resolved Hide resolved
includes/classes/Feature/InstantResults/InstantResults.php Outdated Show resolved Hide resolved
assets/js/instant-results/components/results/didYouMean.js Outdated Show resolved Hide resolved
assets/js/instant-results/components/results/didYouMean.js Outdated Show resolved Hide resolved
assets/js/instant-results/components/results/didYouMean.js Outdated Show resolved Hide resolved
assets/js/instant-results/components/results/didYouMean.js Outdated Show resolved Hide resolved
Comment on lines 40 to 41
<p>{__('Other suggestions', 'elasticpress')}</p>
<ul>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put these inside the wrapper <div>, for easier styling?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burhandodhy Sorry, here I meant that these elements should go inside the ep-search-suggestion div above. So that all the suggestion stuff is inside that div.

@felipeelia felipeelia merged commit f3061f2 into develop Aug 8, 2023
9 checks passed
@felipeelia felipeelia deleted the feature/3409 branch August 8, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "did you mean... ?" support to Instant Results
3 participants