Migrate Status Report to SettingsScreenProvider. #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Migrates the Status Report screen to use the
SettingsScreenProvideradded for 5.0.0. This gives the screen a layout and notification behaviour that's consistent with the new sync screen.Since this involves moving the Download and Copy buttons into the React app, I was also able to fix an issue with encoded HTML entities in the download version of the report so that the Downloaded and Copied versions should match.
How to test the Change
The Status Report screen should now be centered with the same width as the new Sync page. Pressing the Copy button should now display a snackbar notice in the same style as the Copy log button on the sync page.
Changelog Entry
Changed - Tweaked layout and notifications style on the Status Report screen for consistency with the updated Sync page.
Credits
Props @JakePT
Checklist: