Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Comments and Terms by default #3691

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Hide Comments and Terms by default #3691

merged 3 commits into from
Oct 10, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #3064

How to test the Change

Changelog Entry

Changed - Comments and Terms are now hidden by default

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.0.0 milestone Oct 6, 2023
@felipeelia felipeelia linked an issue Oct 6, 2023 that may be closed by this pull request
Future of alternative Indexables #3064
Closed
burhandodhy
burhandodhy approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit fb3884e into 5.0.0 Oct 10, 2023
8 of 9 checks passed
@felipeelia felipeelia deleted the chore/hide-comments-and-terms branch October 10, 2023 20:58
@felipeelia felipeelia mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burhandodhy burhandodhy burhandodhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Future of alternative Indexables
2 participants
@felipeelia @burhandodhy