Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toggle type for active feature control. #3708

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

JakePT
Copy link
Contributor

@JakePT JakePT commented Oct 18, 2023

Description of the Change

Tweaks the settings schema to use toggle type for the enabled/disabled control.

Also makes some corrections/changes to the settings schema of some features:

  • Use label instead of default for the content of markup controls.
  • Use disabled instead of readonly for read-only controls (it turns out this works better).
  • Use actual facets as options for the Filters control in Instant Results (with a correct default).
  • Proper default for Instant Results search behaviour.
  • Use a string value for Did You Mean search behaviour.
  • Removed settings from Search feature that didn't belong there.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia merged commit e2e0d4f into 5.0.0 Oct 18, 2023
12 of 13 checks passed
@felipeelia felipeelia deleted the feature/feature-settings-ui branch October 18, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants