Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: HTML escape issue on the install page #3725

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes the issue where the content of the tooltip on the install page is not showing properly.

Before
image

After fix
image

Closes #

How to test the Change

Changelog Entry

Fixed - Content was not showing properly on the tooltop on install page

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 5.0.0 milestone Oct 27, 2023
Copy link
Member

@felipeelia felipeelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burhandodhy do you mind applying EP's set of tags instead of posts? Thanks!

includes/partials/install-page.php Outdated Show resolved Hide resolved
@felipeelia felipeelia assigned burhandodhy and unassigned felipeelia Oct 27, 2023
@felipeelia felipeelia merged commit adddf5b into 5.0.0 Oct 27, 2023
9 of 13 checks passed
@felipeelia felipeelia deleted the fix/html-escaping-in-tooltip branch October 27, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants