Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Sync page URL after enabling the feature that requires sync #3726

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix: Sync page URL after enabling the feature that requires sync #3726

merged 1 commit into from
Oct 27, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes a issue where feature that requires sync redirect to wrong url.

Closes #

How to test the Change

  1. Enable the feature that requires a new sync. Save the settings.
  2. The user is redirected to the Sync page.
  3. Refresh the page and the user gets an error message “Sorry, you are not allowed to access this page.”
image

Changelog Entry

Fixed - Redirect to correct sync url after enabling feature that requires a new sync

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 5.0.0 milestone Oct 27, 2023
@felipeelia felipeelia merged commit 24b9576 into 5.0.0 Oct 27, 2023
9 of 13 checks passed
@felipeelia felipeelia deleted the fix/sync-url-after-enabling-feature branch October 27, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felipeelia felipeelia

@JakePT JakePT

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@burhandodhy @felipeelia @JakePT