Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Post type setting wasn't respected during sync #3727

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR fixes the issue where the Post Type wasn't respected during the sync from the dashboard. The problem was we were sending the post_types arg to the API where the IndexHelper accept post_type

Closes #

How to test the Change

  1. Go to Sync page.
  2. Only select the Page post type
  3. Make sure EP only sync the Pages

Changelog Entry

Fixed - Post type setting wasn't respected during sync

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 5.0.0 milestone Oct 27, 2023
@felipeelia felipeelia merged commit 47b5da5 into 5.0.0 Oct 27, 2023
9 of 13 checks passed
@felipeelia felipeelia deleted the fix/post-type-settings-wasn't-respected branch October 27, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants