Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Endpoint URL field is not a URL type field #3733

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Oct 30, 2023

Description of the Change

This PR fixes an issue where the Endpoint URL field is not a URL type field on the features page, even though its set a URL type field in the schema https://github.com/10up/ElasticPress/blob/5.0.0/includes/classes/Feature/Autosuggest/Autosuggest.php#L911

Closes #

How to test the Change

Changelog Entry

Fixed - Endpoint URL field is not a URL type field

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy marked this pull request as ready for review October 30, 2023 09:14
@burhandodhy burhandodhy force-pushed the fix/endpoint-url-field-is-not-type-url branch from c78d23b to 810cdaf Compare October 30, 2023 09:18
@burhandodhy burhandodhy changed the title ENDPOINT URL field is not URL field Fix: Endpoint URL field is not a URL type field Oct 30, 2023
@burhandodhy burhandodhy added this to the 5.0.0 milestone Oct 30, 2023
@felipeelia felipeelia assigned JakePT and unassigned felipeelia Oct 31, 2023
@felipeelia felipeelia merged commit 4e9b77f into 5.0.0 Oct 31, 2023
9 of 13 checks passed
@felipeelia felipeelia deleted the fix/endpoint-url-field-is-not-type-url branch October 31, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants