Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n of some strings #3780

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix i18n of some strings #3780

merged 1 commit into from
Dec 6, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #3761

How to test the Change

Changelog Entry

Fixed - Broken i18n of some strings

Credits

Props @felipeelia @iazema

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.0.1 milestone Dec 6, 2023
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit d221fac into develop Dec 6, 2023
14 checks passed
@felipeelia felipeelia deleted the fix/issue-3761 branch December 6, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: some translated strings are displayed in English
2 participants