Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check facet attribute before using it #3781

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Check facet attribute before using it #3781

merged 1 commit into from
Dec 6, 2023

Conversation

felipeelia
Copy link
Member

Description of the Change

Closes #3769

How to test the Change

Changelog Entry

Fixed - PHP warning when using block themes

Credits

Props @felipeelia @tropicandid

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 5.0.1 milestone Dec 6, 2023
@felipeelia felipeelia merged commit 36e6ce9 into develop Dec 6, 2023
13 of 14 checks passed
@felipeelia felipeelia deleted the fix/issue-3769 branch December 6, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Missing isset key check before setting variable against value
1 participant