Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action examples to install svn #60

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

thrijith
Copy link
Member

Description of the Change

This PR updates the example to install svn same as it is done in 10up/action-wordpress-plugin-deploy#155

Closes N/A

@thrijith thrijith requested a review from jeffpaul October 24, 2024 12:45
@thrijith thrijith requested a review from a team as a code owner October 24, 2024 12:45
@jeffpaul jeffpaul added this to the 2.2.0 milestone Oct 24, 2024
@jeffpaul jeffpaul requested review from iamdharmesh and removed request for a team and jeffpaul October 24, 2024 14:23
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thrijith,

Thanks a lot for the PR, it looks good to me. Just a minor suggestion around installing the package, based on GH action docs. Could you please check it once?

Thank you.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @thrijith. @dkotter Could you please help with a quick check and merge as I have made minor change to the PR.

@dkotter dkotter merged commit 6408ae8 into develop Nov 22, 2024
1 check passed
@dkotter dkotter deleted the feature/update-action-examples branch November 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants