Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring over latest changes from the Plugin Deploy Action #7

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Sep 11, 2024

Description of the Change

This Action was copied from our Plugin Deploy Action, with any non-relevant pieces removed. There have been a number of changes to that Action since so this PR brings over the couple that are relevant:

  1. Handle dubious ownership error: Fixes #116: detected dubious ownership issue for github workspace. action-wordpress-plugin-deploy#119
  2. Ensure changed files are added properly to release: Commit files that were built outside of the action action-wordpress-plugin-deploy#130

How to test the Change

Ensure the Action still works as expected

Changelog Entry

Fixed - Handle the error detected dubious ownership in repository at '/github/workspace' when using a .gitattributes file.
Fixed - Ensure built files are included when used without a BUILD_DIR and .distignore file.

Credits

Props @dkotter

Checklist:

@dkotter dkotter added this to the 1.1.0 milestone Sep 11, 2024
@dkotter dkotter self-assigned this Sep 11, 2024
@dkotter dkotter modified the milestones: 1.1.0, 1.0.2 Sep 11, 2024
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dkotter. Code LGTM and it tests well. (Tested on forked repo of one of our OSS repo. Logs: https://github.com/iamdharmesh/autoshare-for-twitter/actions/runs/10833763433)

Note: The spell check action is failing on the PR, but I believe this is expected since it is also failing on the Plugin Deploy action.

@iamdharmesh iamdharmesh merged commit 1206c60 into develop Sep 12, 2024
1 check failed
@iamdharmesh iamdharmesh deleted the feature/match-plugin-deploy branch September 12, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants