Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to example file #144

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Add comments to example file #144

merged 2 commits into from
Jan 8, 2024

Conversation

tarecord
Copy link
Contributor

@tarecord tarecord commented Jan 8, 2024 •
edited
Loading

Description of the Change

This adds comments to help explain the deploy on release example.

Reference: #143 (comment)

How to test the Change

View the file in an editor

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@tarecord tarecord requested a review from a team as a code owner January 8, 2024 15:44
@tarecord tarecord requested review from Sidsector9 and removed request for a team January 8, 2024 15:44
jeffpaul
jeffpaul approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks so much!

@jeffpaul jeffpaul merged commit a045c51 into 10up:add/examples Jan 8, 2024
@jeffpaul jeffpaul added this to the 2.3.0 milestone Jan 8, 2024
@tarecord tarecord deleted the add/documented-example branch January 9, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

@Sidsector9 Sidsector9 Awaiting requested review from Sidsector9 Sidsector9 was automatically assigned from 10up/open-source-practice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tarecord @jeffpaul