Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak/dotorg assets #11

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Tweak/dotorg assets #11

merged 2 commits into from
Aug 11, 2023

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Aug 4, 2023

Description of the Change

This PR adjusts where the plugin image assets are stored so that they'll properly be deployed/updated by our GitHub Actions added in #10. A couple items to consider before merging:

  • Can probably update/remove
    assets/screenshot* releases/svn/assets
    ?
  • Not sure if the icons in assets/images are actually in-use in the plugin or are just part of our scaffold perhaps?

How to test the Change

Changelog Entry

n/a

Credits

Props @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 1.5.0 milestone Aug 4, 2023
@jeffpaul jeffpaul requested review from dkotter and dsawardekar August 4, 2023 13:08
@jeffpaul jeffpaul self-assigned this Aug 4, 2023
@jeffpaul jeffpaul modified the milestones: 1.5.0, 1.6.0 Aug 11, 2023
@jeffpaul jeffpaul merged commit 21f8158 into develop Aug 11, 2023
@jeffpaul jeffpaul deleted the tweak/dotorg-assets branch August 11, 2023 14:43
@jeffpaul
Copy link
Member Author

@dsawardekar any thoughts on my two questions in the checklist of the PR description?

@dkotter dkotter modified the milestones: 1.6.0, 1.5.1 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants