Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes missing name in the Taxonomy options hook #6

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

dsawardekar
Copy link
Collaborator

Description of the Change

Fixes the missing taxonomy name in the block_catalog_taxonomy_options hook.

How to test the Change

Use the block_catalog_taxonomy_options hook and override any of the default taxonomy options in the array.

Changelog Entry

Fixed - Missing name in the block_catalog_taxonomy_options hook

Credits

Props @claytoncollie

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dsawardekar
Copy link
Collaborator Author

@jeffpaul This PR fixes a small issue that @claytoncollie flagged with me last week. The taxonomy name was missing in the block_catalog_taxonomy_options filter hook.

@dsawardekar dsawardekar requested a review from jeffpaul June 26, 2023 07:20
@jeffpaul jeffpaul requested review from tlovett1 and fabiankaegy and removed request for jeffpaul June 29, 2023 15:54
@jeffpaul
Copy link
Member

Pinging @tlovett1 @fabiankaegy for review

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested this out locally but the code looks good to me 👍

@dsawardekar dsawardekar merged commit 5285342 into develop Jul 21, 2023
@jeffpaul jeffpaul added this to the 1.5.0 milestone Aug 2, 2023
@jeffpaul jeffpaul deleted the feature/fix-taxonomy-options-hook branch November 10, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants