Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TypeScript to Repository #267

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

fabiankaegy
Copy link
Member

Description of the Change

This is an alternative to #191 where we gradually convert the components over instead of having one large break. With this initial PR we are introducing the general tsconfig file and are adding the types key to the package.json

Closes #

How to test the Change

Changelog Entry

Added - Export types from project with NPM package

Credits

Props @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions
Copy link

🎉 A new testing version of this package has been published to NPM. You can install it with npm install @10up/block-components@testing-267

@github-actions
Copy link

Size Change: 0 B

Total Size: 65.1 kB

ℹ️ View Unchanged
Filename Size
dist/index.js 65.1 kB

compressed-size-action

@cypress
Copy link

cypress bot commented Sep 26, 2023

Passing run #659 ↗︎

0 6 0 0 Flakiness 0

Details:

add types deffinition file to package.json
Project: 10up Block Components Commit: a9b1976e5c
Status: Passed Duration: 02:36 💡
Started: Sep 26, 2023 8:32 AM Ended: Sep 26, 2023 8:35 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@fabiankaegy fabiankaegy merged commit eec43fa into develop Sep 26, 2023
@fabiankaegy fabiankaegy deleted the feature/setup-repository-for-typescript branch September 26, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality [Type] Documentation Improvements or additions to documentation [Type] Enhancement New feature or request [Type] Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant