Fix: refactor use filtered list TypeScript #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
commented
Jan 23, 2024
| const matchedNames = fuzzy.filter(propertyList, searchTerm); | ||
| return matchedNames.map((index) => list[index]); | ||
| const results = matchedNames?.map((index) => list[index]) || []; |
There was a problem hiding this comment.
This refactor actually uncovered a bug that was fixed here
|
Size Change: +24 B (0%) Total Size: 65.5 kB
|
|
🎉 A new testing version of this package has been published to NPM. You can install it with |
4 failed tests on run #696 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| IconPicker > allows the user to use the post picker to change an icon and displays it |
Screenshots
Video
|
|
Image.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Image > allows the user to pick an image from the media library and displays it inline |
Screenshots
Video
|
|
Link.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Link > allows the editor to pick a link directly inline |
Screenshots
Video
|
|
registerBlockExtension.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| registerBlockExtension > ensure the new setting shows up and doesn't cause deprecation errors |
Screenshots
Video
|
|
Review all test suite changes for PR #284 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
useFilteredListhook to TypeScript