Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label fields on video editing #232

Merged
merged 4 commits into from
Oct 28, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Oct 18, 2021

Description of the Change

The field label is not sent on the form submit when a video is updated. This PR fixes that.

Alternate Designs

Benefits

The user can add/remove labels to a video.

Possible Drawbacks

Verification Process

  1. Edit a video and add/remove labels
  2. Save the video
  3. Refresh the page and check if the value for the label is correct

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Fixed label fields on video editing.

oscarssanchez
oscarssanchez previously approved these changes Oct 20, 2021
@Rahmon Rahmon merged commit 7e17afb into develop Oct 28, 2021
@Rahmon Rahmon deleted the fix/label-field-on-submit-form-sit-2551 branch October 28, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants