Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/display video url #247

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Feature/display video url #247

merged 3 commits into from
Jan 17, 2022

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

This PR introduces a change to display the URL version of each videos corresponding to an iframe if it's being embedded. To keep consistency, it takes the default player to construct the URL as default player should always be available.

Screen Shot 2022-01-16 at 22 08 32

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@oscarssanchez oscarssanchez merged commit 4a243c6 into develop Jan 17, 2022
@oscarssanchez oscarssanchez deleted the feature/display-video-url branch January 17, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants