E2e tests #288
Merged
E2e tests #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
approved these changes
Oct 3, 2022
Comment on lines
+16
to
+21
| name: ${{ matrix.core.name }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| core: | ||
| - {name: 'WP latest', version: 'latest'} |
There was a problem hiding this comment.
@oscarssanchez are you planning to test it in multiple WP versions?
There was a problem hiding this comment.
Also, any particular reason why we can't use a more recent node version instead of 12?
There was a problem hiding this comment.
For now just the latest version, originally I was testing it on other ones but tests were taking a long time.
As for node 12, there's some 10up packages that are incompatible with newer versions. We'll need to move to 10up toolkit but I'd like to get time approval from Apurva before moving forward with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: