Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scope of phpcs linting #299

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Reduce scope of phpcs linting #299

merged 4 commits into from
Mar 6, 2023

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

This PR reduces the scope of lint and lint-fix commands. Previously, we were scanning all the files within the brightcove plugin folder, now, the scope is limited to php files.

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@oscarssanchez oscarssanchez changed the title Reduces scope of phpcs linting Reduce scope of phpcs linting Oct 22, 2022
@jeffpaul jeffpaul added this to the 2.8.1 milestone Dec 2, 2022
@oscarssanchez oscarssanchez merged commit 4a141ba into develop Mar 6, 2023
@oscarssanchez oscarssanchez deleted the fix/phpcs-scope branch March 6, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants