Bugfix: Prevent API calls when Brightcove has not been configured yet #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
felipeelia
approved these changes
Jun 21, 2023
oscarssanchez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR checks if the Brightcove accounts have been set, and if they are not, it prevents loading code that doesn't make sense to be loaded before.
The fix specifically targets #198 and #231 where remote requests are being fired. It doesn't make sense to fire these if the plugin has not been configured with a valid Brightcove Account first.
It also solves a bug related to the account data when we do not have that yet.
Closes #198
Closes #231
How to test the Change
Changelog Entry
Credits
Props @oscarssanchez
Checklist: