Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add support for special characters #373

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix: Add support for special characters #373

merged 1 commit into from
Feb 7, 2024

Conversation

burhandodhy
Copy link
Collaborator

@burhandodhy burhandodhy commented Feb 7, 2024

Description of the Change

This PR fixes an issue where the special characters get encoded due to the utf8_uri_encode function in sanitize_payload_item and sanitize_payload_args_recursive functions.

Closes #348

How to test the Change

  1. Upload or edit a Brightcove video
  2. Use a special character in the Name field such as ’, —, or é.
  3. Reload the page and confirm the field doesn't have encoded characters anymore

Changelog Entry

Fixed - Add support for special characters

Credits

Props @burhandodhy @cr0ybot

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy merged commit b35126f into develop Feb 7, 2024
11 checks passed
@burhandodhy burhandodhy deleted the fix/348 branch February 7, 2024 12:55
@jeffpaul jeffpaul added this to the 2.8.5 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support special characters: Text sanitization is too extreme
3 participants