Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification icon in the menu shows all the time unless you configure all services. #100

Closed
eflorea opened this issue Jul 12, 2019 · 3 comments · Fixed by #142
Closed

Notification icon in the menu shows all the time unless you configure all services. #100

eflorea opened this issue Jul 12, 2019 · 3 comments · Fixed by #142
Assignees
Labels
type:bug Something isn't working.
Milestone

Comments

@eflorea
Copy link
Contributor

eflorea commented Jul 12, 2019

Describe the bug

Notification icon in the Admin Menu shows all the time unless you configure all the services.

Steps to Reproduce

  1. Configure only Image Processing settings
  2. Notification still shows and it's confusing feels like something is requiring attention but in reality no - maybe I don't want to use Language Processing.

Screenshots

Screen Shot 2019-07-12 at 10 24 53 AM

@eflorea eflorea added the type:bug Something isn't working. label Jul 12, 2019
@jeffpaul jeffpaul added this to the Future Release milestone Jul 15, 2019
@jeffpaul
Copy link
Member

@eflorea thanks for the feedback, would happily review a PR to resolve this, but otherwise have milestoned this to get resolved in an upcoming release.

@jeffpaul jeffpaul modified the milestones: Future Release, 1.4.0 Jul 31, 2019
@helen
Copy link
Contributor

helen commented Sep 25, 2019

Since this will be more involved as more providers are added, I think maybe it's better if we either remove it for now and revisit holistically later, or tie it to having a valid registration key instead. Thoughts/preferences?

@jeffpaul
Copy link
Member

After discussing with @helen, let's reduce this to just be an alert when no reg key has been set. We want folks to have ClassifAI updates available to them based on all the great stuff on the roadmap, so prompting them to complete that step seems worthwhile. It doesn't seem necessary to continue to alert them if any of the services are unconfigured as they're likely to figure that out if they're not seeing tagging/alt-text/etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants