Show admin menu notice (!) for lack of registration instead of specific service setup #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Show admin menu notice (!) for lack of registration instead of specific service setup.
Alternate Designs
Removing the (!) entirely.
Benefits
Will not show an error-ish state just because NLU is not configured (i.e. you may just want to set up image processing).
Possible Drawbacks
None?
Verification Process
Changing values in the UI. Noticed a bug in the reg key checker endpoint 😬
Checklist:
Applicable Issues
Fixes #100