Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit 1.5.0 to VIP for review #182

Closed
jeffpaul opened this issue Feb 13, 2020 · 3 comments · Fixed by #287
Closed

Submit 1.5.0 to VIP for review #182

jeffpaul opened this issue Feb 13, 2020 · 3 comments · Fixed by #287
Assignees
Labels
type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Member

Is your enhancement related to a problem? Please describe.
We'll want to ensure that any one on WordPress VIP are able to use ClassifAI, but we're not currently certain that's the case.

Describe the solution you'd like
Submit ClassifAI for VIP review and work to resolve any issues identified within a quickly following release.

Designs

n/a

Describe alternatives you've considered

n/a

Additional context

n/a

@jeffpaul jeffpaul added the type:enhancement New feature or request. label Feb 13, 2020
@jeffpaul jeffpaul added this to the 1.6.0 milestone Feb 13, 2020
@jeffpaul jeffpaul self-assigned this Feb 13, 2020
@jeffpaul
Copy link
Member Author

jeffpaul commented May 4, 2020

@ryanwelcher I'm not certain if we're able to submit this to VIP for review or if it needs to come from a project team working with VIP, but either way I figure we can run ClassifAI through the VIP coding standards to see what pops up to look into resolving perhaps?

@ryanwelcher
Copy link
Contributor

@jeffpaul I've run the 1.5.1 release though phpcs and there are some items that will need to be addressed. I'll start a PR with the changes.

@jeffpaul
Copy link
Member Author

@dinhtungdu probably worthwhile updating the Linting action to also run VIPCS to help close out this task for 1.7.0.

@ryanwelcher ryanwelcher removed their assignment May 11, 2021
@dinhtungdu dinhtungdu mentioned this issue Jun 4, 2021
6 tasks
@jeffpaul jeffpaul linked a pull request Jun 4, 2021 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants