Ensuring Classifiai passes VIP code scans #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helen
suggested changes
Sep 29, 2020
There was a problem hiding this comment.
Marking this as needs changes because it's not ready yet - there do appear to be some things that legitimately need changes here and it's not ready for merge. This still needs a full review with comments at some point, going to punt out of 1.6.0 for now unless somebody picks this up.
dinhtungdu
force-pushed
the
feature/vip-compatibility
branch
2 times, most recently
from
1eb38ca
to
3ff4e5c
Compare
|
Closing in favor of #287. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
#182
Changelog Entry