Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt and payload filter standardization #586

Closed
1 task done
jeffpaul opened this issue Oct 16, 2023 · 1 comment · Fixed by #604
Closed
1 task done

Prompt and payload filter standardization #586

jeffpaul opened this issue Oct 16, 2023 · 1 comment · Fixed by #604
Assignees
Labels
type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Member

Is your enhancement related to a problem? Please describe.

The focus here is on ensuring that filters exist for the prompts and/or payloads of all features, are standardized to a reliable format (e.g., classifai_{feature}_{service}_prompt), and that any pre-existing filters that need to be standardized are updated/deprecated accordingly (e.g. soft deprecation in one major release, hard deprecated in a subsequent major release). This will allow for reliable filters regardless of feature and service provider and that ClassifAI’s Developer Documentation becomes easier to read and understand.

The potential approach to working on this could be:

  • Go through the plugin and make a note of all hooks (probably pull these into a Google Sheet)
  • During this process, make a note of any places that are missing hooks that would benefit from having one added
  • Once done, we can have a conversation on which hooks we should add and which of the existing hooks should be renamed
  • After all this, the actual work can be done

Designs

n/a

Describe alternatives you've considered

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Oct 16, 2023
@jeffpaul jeffpaul added this to the 2.4.0 milestone Oct 16, 2023
@faisal-alvi
Copy link
Member

Update: We are working on a sheet that lists all existing filters and what modifications need to be made. The sheet is available here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants