-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/586 New Filters #604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-alvi
requested review from
dkotter,
jeffpaul and
a team
as code owners
October 24, 2023 10:03
dkotter
reviewed
Oct 24, 2023
dkotter
reviewed
Oct 24, 2023
dkotter
reviewed
Oct 24, 2023
dkotter
reviewed
Oct 24, 2023
dkotter
reviewed
Oct 24, 2023
dkotter
reviewed
Oct 24, 2023
dkotter
reviewed
Oct 24, 2023
dkotter
requested changes
Oct 24, 2023
dkotter
approved these changes
Oct 25, 2023
berkod
approved these changes
Oct 26, 2023
jeffpaul
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that this was reviewed in UAT today and approved for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds new filters and a new (second) parameter to pass the feature name in the OpenAPI/APIRequest class. Also, fixed a few hook names in their doc comments.
Closes #586
How to test the Change
By using any of the new filters and see if it works.
Changelog Entry
Credits
Props @jeffpaul @dkotter @faisal-alvi
Checklist: