Add image tags and alt text to search #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is modeled after the core function `_filter_query_attachment_filenames()`
ryanwelcher
reviewed
Sep 20, 2019
ryanwelcher
previously approved these changes
Sep 20, 2019
It's key-specific anyway and was causing linting issues in Helpers.php.
ryanwelcher
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Allow image searches to search tags and alt text. This is modeled after the core function
_filter_query_attachment_filenames()Alternate Designs
n/a
Benefits
More intuitive finding of your media.
Possible Drawbacks
Slow queries. It would be a good place to suggest usage of Elasticsearch/ElasticPress if you find that this is becoming slow.
Verification Process
Tested searches for unique keywords in alt text and generated tag meta.
Checklist:
Applicable Issues
See #75