Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test - change image URL to post-5.3-generated size #162

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

johnwatkins0
Copy link
Member

Description of the Change

Before WP 5.3, one of the integration tests for the get_largest_acceptable_image_url method returned a large-size version of a test image. Since 5.3 introduced the new 1536x1536 size to core, the method now returns the image at that size.

This one-line change simply updates the file name to make the test pass.

Benefits

Passing tests.

Verification Process

If the Travis build passes, this update is successful.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Is applicable to #157 but does not come close to resolving it.

@johnwatkins0 johnwatkins0 self-assigned this Jan 14, 2020
@jeffpaul jeffpaul added this to the 1.5.0 milestone Jan 17, 2020
@jeffpaul jeffpaul added the type:bug Something isn't working. label Jan 17, 2020
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me 👌

@jeffpaul jeffpaul merged commit d65f083 into develop Jan 17, 2020
@jeffpaul jeffpaul deleted the fix/image-integration-test branch March 5, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants